release v0.34.4 - #200
Merged
Merged
Conversation
bgrant
reviewed
Aug 7, 2026
| - Fix filter model cache serving the wrong object's collection for callable filters over to-many relations (forward `GenericRelation`, `ManyToManyField`, or reverse FK). Such fields were mistaken for scalar foreign keys and cached by a key derived from a transient related manager's memory address; after garbage collection that address could be reused by another owner's manager, forging a cache hit and returning the wrong collection. To-many relations now fall back to the per-instance cache key. | ||
|
|
||
| # [0.34.4] | ||
| - [PR 197](https://github.com/salesforce/django-declarative-apis/pull/197) Fix filter model cache serving the wrong object's collection for callable filters over to-many relations (forward `GenericRelation`, `ManyToManyField`, or reverse FK). Such fields were mistaken for scalar foreign keys and cached by a key derived from a transient related manager's memory address; after garbage collection that address could be reused by another owner's manager, forging a cache hit and returning the wrong collection. To-many relations now fall back to the per-instance cache key. |
Collaborator
There was a problem hiding this comment.
Long CHANGELOG entry! We usually keep the changelog entries short and link to the PR (which hopefully has a good description).
Not a blocking issue.
bgrant
previously approved these changes
Aug 7, 2026
bgrant
left a comment
bgrant
left a comment
Collaborator
There was a problem hiding this comment.
Minor nitpick, but approved! Thanks.
bgrant
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bumpversion patch[0.34.4]heading and add a fresh empty[Unreleased]sectionTest plan