376 refactor mail jira reply notebook config - #406
Open
Michelle4929 wants to merge 2 commits into
Open
Conversation
5 tasks
Michelle4929
force-pushed
the
376-refactor-mail-jira-notebook-config
branch
from
May 9, 2026 23:35
3e07427 to
343a652
Compare
cfuke1
approved these changes
May 11, 2026
cfuke1
left a comment
cfuke1
left a comment
Collaborator
There was a problem hiding this comment.
Was able to run everything.
| @@ -0,0 +1,148 @@ | |||
| # -*- yaml -*- | |||
Collaborator
There was a problem hiding this comment.
analysisE and analysisI look the same just comments out different parts
| save_folder_path: ../../rawdata/geronimo/mod_mbox/save_mbox_mail/ | ||
| # mbox_file_path is for use only with parse_mbox() function. It is the file to parse | ||
| # mbox_file_path: ../../rawdata/geronimo/mod_mbox/save_mbox_mail/geronimo.mbox | ||
| project_key_2: |
Collaborator
There was a problem hiding this comment.
Only difference besides for links between geronimo and openssl is lines 55 to 70, format looks like a copy and paste otherwise.
john-a-flinn
approved these changes
May 11, 2026
john-a-flinn
left a comment
john-a-flinn
left a comment
Collaborator
There was a problem hiding this comment.
Code between similar files has the same structure and all files share a similar the overall structure.
Signed-off-by: Michelle4929 <giyoung7@hawaii.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Refactoring mail, jira, and reply configurations into taking 2 configurations (project vs analysis), more details in issue #376 .
New Implementations
Project: Configurations that typically do not change between analyses
Analysis Specific: Configurations that do change depending on the analysis
analysisE.yml
analysisI.yml
Changed Notebooks: These notebooks now read 2 configs
Example
Before:
conf <- parse_config("../conf/geronimo.yml")
After:
project <- parse_config("../conf/geronimo_project.yml")
analysis <- parse_config("../conf/analysisE.yml")