359 Refactoring Configs for Gitlog - #365
Open
Michelle4929 wants to merge 11 commits into
Open
Conversation
Michelle4929
changed the title
cfuke1
approved these changes
Mar 24, 2026
cfuke1
left a comment
cfuke1
left a comment
Collaborator
There was a problem hiding this comment.
Was able to run on my machine with no issues and the refactored changes all look good to me.
|
|
||
| ```{r} | ||
| tool <- parse_config("../tools.yml") | ||
| conf <- parse_config("../conf/kaiaulu.yml") |
Collaborator
There was a problem hiding this comment.
A lot of uncommenting, were these commented for a reason?
| @@ -0,0 +1,82 @@ | |||
| # -*- yaml -*- | |||
Collaborator
There was a problem hiding this comment.
Far as I can tell helix and kaiaulu have the same format var order
| @@ -0,0 +1,125 @@ | |||
| # -*- yaml -*- | |||
Collaborator
There was a problem hiding this comment.
Analysis 1 and 2 both share the same format
john-a-flinn
requested changes
Mar 30, 2026
john-a-flinn
left a comment
john-a-flinn
left a comment
Collaborator
There was a problem hiding this comment.
What are the propose of the changes in the Rmd files? the ymls look fine
john-a-flinn
approved these changes
Apr 3, 2026
john-a-flinn
left a comment
john-a-flinn
left a comment
Collaborator
There was a problem hiding this comment.
Updated Rmd with comments, looks good
7 tasks
Signed-off-by: Michelle4929 <giyoung7@hawaii.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Refactoring gitlog configurations into taking 2 configurations (project vs analysis), more details in issue #359.
New Implementations
Before: conf <- parse_config("../conf/helix.yml")
After: project <- parse_config("../conf/kaiaulu_project.yml")
analysis <- parse_config("../conf/analysisH.yml")