Skip to content

feat: add emptyList, SearchBar components and upgrade expo SDK#39

Open
hoangSTS wants to merge 1 commit intofeat/update_componentsfrom
feat/add_emptylist_searchbar_components_and_upgrade_expo_sdk
Open

feat: add emptyList, SearchBar components and upgrade expo SDK#39
hoangSTS wants to merge 1 commit intofeat/update_componentsfrom
feat/add_emptylist_searchbar_components_and_upgrade_expo_sdk

Conversation

@hoangSTS
Copy link
Contributor

@hoangSTS hoangSTS commented Oct 8, 2025

  • Add EmptyList and SearchBar components
  • Upgrade Expo SDK

@coderabbitai
Copy link

coderabbitai bot commented Oct 8, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/add_emptylist_searchbar_components_and_upgrade_expo_sdk

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

descriptionStyle,
}) => (
<View style={[styles.container, style]}>
{icon && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should use double negation for this
!!icon instead icon

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in PR #42

style={[styles.icon, { tintColor: iconColor, width: iconSize, height: iconSize }]}
/>
)}
{title && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same icon props

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in PR #42

}
autoCorrect={false}
returnKeyType="search"
{...rest}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should support a button icon at the end of the input to clear all the text, and have a prop to enable/disable this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants