Skip to content

refactor(navbar): eliminate redundant theme-switching script to resol…#752

Open
Elchedli wants to merge 1 commit intosaicaca:mainfrom
Elchedli:fix/switchThemeRendering
Open

refactor(navbar): eliminate redundant theme-switching script to resol…#752
Elchedli wants to merge 1 commit intosaicaca:mainfrom
Elchedli:fix/switchThemeRendering

Conversation

@Elchedli
Copy link
Copy Markdown

@Elchedli Elchedli commented Apr 8, 2026

Type of change

  • Bug fix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please describe):

Checklist

  • I have read the CONTRIBUTING document.
  • I have checked to ensure that this Pull Request is not for personal changes.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings.

Changes

This PR eliminates an old JavaScript code in src/components/Navbar.astro that manually handled theme toggling. This is because the said logic is already contained in LightDarkSwitch.svelte, hence rendering the Astro script obsolete. Removing this code may prevent future event collissions, reduces the JavaScript payload, and ensures a single source of truth for the site's color scheme state.

How To Test

  • Verification by switching the dark/light theme switch.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 8, 2026

@Elchedli is attempting to deploy a commit to the zephyirdgmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Elchedli Elchedli force-pushed the fix/switchThemeRendering branch from 28cf06f to 201b9bc Compare April 8, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant