refactor(navbar): eliminate redundant theme-switching script to resol…#752
Open
Elchedli wants to merge 1 commit intosaicaca:mainfrom
Open
refactor(navbar): eliminate redundant theme-switching script to resol…#752Elchedli wants to merge 1 commit intosaicaca:mainfrom
Elchedli wants to merge 1 commit intosaicaca:mainfrom
Conversation
|
@Elchedli is attempting to deploy a commit to the zephyirdgmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
…ve event collision
28cf06f to
201b9bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Checklist
Changes
This PR eliminates an old JavaScript code in
src/components/Navbar.astrothat manually handled theme toggling. This is because the said logic is already contained inLightDarkSwitch.svelte, hence rendering the Astro script obsolete. Removing this code may prevent future event collissions, reduces the JavaScript payload, and ensures a single source of truth for the site's color scheme state.How To Test