Conversation
ADCDevice.Get2 assigned the raw value to a 2048-wide zone by flooring, so zone 0 covered only [0, 2047] - entirely on the positive side of true center - and the dead zone extended one zone (2048 counts) further in the positive direction than in the negative one. The stick therefore registered movement much earlier in one direction, observed as a slight drift near center. Add half a zone before shifting so the assignment rounds to the nearest zone and the dead zone becomes symmetric. Both targets carry the same copy of ADCDevice; confirmed on sg48key hardware.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADCDevice.Get2 assigned the raw value to a 2048-wide zone by flooring, so zone 0 covered only [0, 2047] - entirely on the positive side of true center - and the dead zone extended one zone (2048 counts) further in the positive direction than in the negative one. The stick therefore registered movement much earlier in one direction, observed as a slight drift near center. Add half a zone before shifting so the assignment rounds to the nearest zone and the dead zone becomes symmetric.
Both targets carry the same copy of ADCDevice; confirmed on sg48key hardware.