You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for addressing #836 — the second sentence (code-only corpora skip the LLM pass entirely) is accurate and worth documenting. The first sentence needs a correction though.
Code files are not sent to the LLM semantic extractor in the normal pipeline.
This is only true for code-only corpora. In mixed corpora (code + docs/papers/images), code files do go through the LLM — skill.md line 318 explicitly says: "Code files: focus on semantic edges AST cannot find (call relationships, shared data, arch patterns)." The current wording would mislead users with a mixed corpus.
Suggested replacement:
In a code-only corpus, the LLM semantic pass is skipped entirely — Tree-sitter handles all extraction. In mixed corpora (code alongside docs, papers, or images), code files also go through the LLM, but only to extract semantic edges that AST cannot find (call relationships, shared data, architectural patterns) — never to re-extract imports or structure.
Update the test to match and this is good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
python -m pytest tests/test_install_strings.pyNotes
Closes #836