You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
AST finds unresolved calls, optional LSP hooks try to resolve them, and only boringly safe evidence gets promoted back into the graph. No more turning every first, map, or id into a fake god node. Hooks are opt-in, cached, documented, and wired.
This is a well-engineered addition — the two-stage architecture (AST records unresolved_calls, optional LSP hooks promote them to INFERRED edges) is clean, the conservative promotion policy is correct, and the 1133-line test file is thorough. Three fixes needed before we merge:
1. LSP failure should degrade gracefully (must fix)
In watch.py around the LSP enrichment call, a hook failure raises an exception that causes the entire watch rebuild to return False. Since hooks are opt-in enrichment (not core), a failure should log a warning and continue with the pre-enrichment graph — not abort the rebuild. Please wrap the LSP enrichment call in a try/except that logs and continues.
2. Zombie processes on LSP client shutdown (must fix)
In lsp_definition_hook.py, the close() method calls proc.terminate() on timeout but never follows it with proc.wait(). This leaves zombie processes. Please add proc.wait(timeout=5) (with a kill() fallback) after terminate().
3. required default is asymmetric with docs (should fix)
The code defaults required=True for omitted hook config fields, but every example in docs/lsp-hooks.md sets "required": false. A user following the docs verbatim gets optional hooks, but one who omits the field gets required hooks — surprising. Please either flip the default to False or update the docs examples to omit the field.
Once these three are addressed we'll merge. Great work on this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AST finds unresolved calls, optional LSP hooks try to resolve them, and only boringly safe evidence gets promoted back into the graph. No more turning every
first,map, oridinto a fake god node. Hooks are opt-in, cached, documented, and wired.