Skip to content

feat: add allowance module for Citrea mainnet and testnet#100

Open
Emosaddd wants to merge 1 commit intosafe-global:mainfrom
protofire:feat/add-allowance-module-citrea
Open

feat: add allowance module for Citrea mainnet and testnet#100
Emosaddd wants to merge 1 commit intosafe-global:mainfrom
protofire:feat/add-allowance-module-citrea

Conversation

@Emosaddd
Copy link
Copy Markdown
Contributor

@Emosaddd Emosaddd commented Mar 2, 2026

testnet

deploying "AllowanceModule" (tx: 0xcffb87cda2be98e4757f0e0c07d2b6de4e2fb36e8303fd03dd7af52eea7da6e4)...: deployed at 0xAA46724893dedD72658219405185Fb0Fc91e091C with 3273619 gas

mainnet

deploying "AllowanceModule" (tx: 0x6ffb7920c5a4aac78e8a5eab83301fb54075a4717a3e38d7b0ae16e94f93d4f7)...: deployed at 0xAA46724893dedD72658219405185Fb0Fc91e091C with 3273619 gas

@Emosaddd Emosaddd requested a review from a team as a code owner March 2, 2026 09:22
@Emosaddd
Copy link
Copy Markdown
Contributor Author

Hello @dasanra
could we proceed here?

@Zalens
Copy link
Copy Markdown
Member

Zalens commented Mar 18, 2026

Hey @Emosaddd, this PR has a merge conflict with main (caused by #109 which recently merged and touched the same area of allowance-module.json).

Could you rebase onto main? The conflict is straightforward — just the networkAddresses section in src/assets/allowance-module/v0.1.1/allowance-module.json.

@Emosaddd Emosaddd force-pushed the feat/add-allowance-module-citrea branch from a97fa6d to 74c8637 Compare March 19, 2026 17:06
@Emosaddd Emosaddd force-pushed the feat/add-allowance-module-citrea branch from 74c8637 to fbe7fce Compare March 19, 2026 17:11
@Emosaddd
Copy link
Copy Markdown
Contributor Author

Hey @Emosaddd, this PR has a merge conflict with main (caused by #109 which recently merged and touched the same area of allowance-module.json).

Could you rebase onto main? The conflict is straightforward — just the networkAddresses section in src/assets/allowance-module/v0.1.1/allowance-module.json.

Hey @Zalens
done

Copy link
Copy Markdown
Member

@Zalens Zalens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AllowanceModule verified on-chain for Citrea mainnet (4114) and testnet (5115). Address matches canonical. Also fixes pre-existing sort order issue for chain 3637. Numeric sorting correct after change.

@Zalens
Copy link
Copy Markdown
Member

Zalens commented Apr 15, 2026

This PR has merge conflicts after other allowance module PRs were merged. Could you rebase on main? Everything else is approved — on-chain verification passed and conventions look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants