fix(CalDAV/Backend/PDO): bind transparent as int in updateCalendar#1637
Open
sylvinus wants to merge 1 commit intosabre-io:masterfrom
Open
fix(CalDAV/Backend/PDO): bind transparent as int in updateCalendar#1637sylvinus wants to merge 1 commit intosabre-io:masterfrom
sylvinus wants to merge 1 commit intosabre-io:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1637 +/- ##
=========================================
Coverage 97.26% 97.26%
- Complexity 2844 2845 +1
=========================================
Files 175 175
Lines 8887 8887
=========================================
Hits 8644 8644
Misses 243 243 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
`updateCalendar` stored the `transparent` field as a PHP boolean, which the pgsql PDO driver serializes as the empty string `''` when the value is `false`. The `transparent SMALLINT NOT NULL` column then rejects the parameter with SQLSTATE 22P02. This looks like a follow-up, 10 years later (!), of sabre-io#816 :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updateCalendarstored thetransparentfield as a PHP boolean, which the pgsql PDO driver serializes as the empty string''when the value isfalse. Thetransparent SMALLINT NOT NULLcolumn then rejects the parameter with SQLSTATE 22P02.This looks like a follow-up, 10 years later (!), of #816 :-)