Conversation
- Avoid using Matrix::solve(A); instead use Matrix::solve(A, b)
- Copied function to avoid dependency - Drop MASS dependency
Owner
Author
|
Hi @kylebutts - I am fairly sorry about merging already. Had not intended this but clicked the wrong button in vscode... Is it ok if we keep the branch as is and if I push some of the changes we discussed (for example matrix inversion via armadillo?). |
Owner
Author
|
I have updated the branch with the most recent updates I have submitted to CRAN on Sunday. |
Contributor
|
No problem! Just waiting on the fixest merge to submit the new version to CRAN; so long as you don't have plans to do anything else before then, should be fine :-) |
Owner
Author
I will try not to merge into main until then 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.