Open
Conversation
[why] If the user has a font where the widths are all zero (which can happen due to a fontforge bug if that font has been generated previously already) it is impossible to rectify the situation by giving an explicit cell size. [how] First apply the settings from --cell and only afterwards check if the width is sane - like it is already done for the font height. [note] This will possibly not help if the same (broken) version of fontforge is again used with the font-patcher script as there is the possibility that fontforge 'corrects' our carfully set width to zero again on generation. [note] Patch created with the help of some LLM tool. Authored-by: Ning Wang @ningw42 Signed-off-by: Fini Jastrow <[email protected]>
[why] When the scale rules include the two cell directive "2" the right aligned icons are correctly moved, but the centered icons get not really centered within the target of a 2 cell width. [how] Take the target width (1.0 or 2.0) into account also for centered glyphs. [note] Patch created with the help of some LLM tool. Authored-by: Ning Wang @ningw42 Signed-off-by: Fini Jastrow <[email protected]>
|
Thank you for the instructions in #1774. I am not sure it reaches the quality requirement to be merged. I only tested those two things for my own use cases. If you are ok with it, I don't have any objection :P . Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two changes by @ningw42 that came up when he wanted to create a 2 cell wide monospaced SymbolsOnly font.
Thanks for the contribution.
Requirements / Checklist
Issue number where discussion took place: #xxx
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
#1774
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)