feat: use fgetpwent_r on linux #30
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posting to get some conversation going around openness to using
fgetpwent_ron the platforms that provide it (i.e., Linux).Per docs, it's actually reentrant and could be used to implement a non-unsafe version of group and user enumeration on the platforms that support it. That somewhat begs the question of whether it's feasible (and/or a good idea) to provide functions that are only unsafe on some platforms. It would be great to get your feedback on whether you'd consider something in this direction.
(Aside: this macOS man page indicates that
getpwentis thread-safe on that platform because they happen to place its internal buffer in a thread-specific structure. Would need to more properly validate that, though.)