chore: move rust-vmm deps to workspace dependencies#921
Open
ANISH-SR wants to merge 3 commits intorust-vmm:mainfrom
Open
chore: move rust-vmm deps to workspace dependencies#921ANISH-SR wants to merge 3 commits intorust-vmm:mainfrom
ANISH-SR wants to merge 3 commits intorust-vmm:mainfrom
Conversation
ANISH-SR
requested review from
dorindabassey,
epilys,
mz-pdm,
stefano-garzarella,
stsquad and
vireshk
as code owners
Signed-off-by: ANISH-SR <rawatanish08@gmail.com>
Signed-off-by: ANISH-SR <rawatanish08@gmail.com>
Collaborator
|
Hi @ANISH-SR, can you rebase your PRs? Thanks! |
Author
|
Hi @dorindabassey , I have just fixed the merge conflicts. Do lmk if any other change is needed here! thanks : ) |
stefano-garzarella
requested changes
Jan 12, 2026
Member
There was a problem hiding this comment.
Why having a changelog for the entire workspace?
Which will be the "Upcoming release" ?
| vhost = { version = "0.15", features = ["vhost-user-backend"] } | ||
| vhost-user-backend = "0.21" | ||
| virtio-bindings = "0.2.5" | ||
| virtio-queue = { version = "0.17", features = ["test-utils"] } |
Member
There was a problem hiding this comment.
So now we are enabling test-utils feature for tests but also for code, why?
Member
There was a problem hiding this comment.
Yes, this is wrong. AI slop or just slop, maybe.
| vhost-user-backend = "0.21" | ||
| virtio-bindings = "0.2.5" | ||
| virtio-queue = { version = "0.17", features = ["test-utils"] } | ||
| vm-memory = { version = "0.17.1", features = ["backend-mmap", "backend-atomic"] } |
Member
|
Each commit should explain the "why" of a change, please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Closes #906