Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug only happend if you try to compile this library in release mode within the repo directory. This bug does not effect consumers of this library.
How to reproduce
cargo build --release(it might be necessary to runcargo cleanif the repo was compiled in release mode before)What happens
After changing
build.rsto includecmd.arg("-vv")in thebuild_uefi_bootloaderfunction and also building usingcargo build -r -vv --no-default-features --features uefiwe can see that cargo hangs at the following step:The issue is that the artifact directory for the uefi crate and for the bootloader crate are the same.
cargo buildfor the bootloader crate locks the artifact directory.build.rsis executed which tries to runcargo install bootloader-x86_64-uefi --path uefi .....(the--pathargument is only used when building localy and therefor this bug does not effect downstream consumers of this crate).cargo installfor the uefi subcrate tries to lock the same artifact directoryImpact
As far as I can tell it is impossible to run
cargo test --release. Otherwise this is pretty harmless.