Skip to content

Comments

useless_conversion: also fire inside compiler desugarings#16594

Open
lapla-cogito wants to merge 1 commit intorust-lang:masterfrom
lapla-cogito:issue_16590
Open

useless_conversion: also fire inside compiler desugarings#16594
lapla-cogito wants to merge 1 commit intorust-lang:masterfrom
lapla-cogito:issue_16590

Conversation

@lapla-cogito
Copy link
Contributor

@lapla-cogito lapla-cogito commented Feb 20, 2026

Using e.span.from_expansion() alone prevented the lint from firing within compiler-desugared expressions, e.g. async fn, for loops, or ?.

changelog: [useless_conversion]: also fire inside compiler desugarings

close #16590

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 20, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 20, 2026

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from Jarcho, dswij, llogiq, samueltardieu

@github-actions
Copy link

github-actions bot commented Feb 20, 2026

Lintcheck changes for d65fe0b

Lint Added Removed Changed
clippy::useless_conversion 6 0 1

This comment will be updated if you push new changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useless_conversion when zipping vecs not triggered in async fn

3 participants