Move resize handle to lower left#356
Open
jason00111 wants to merge 1 commit into
Open
Conversation
rugk
reviewed
May 11, 2026
Owner
rugk
left a comment
There was a problem hiding this comment.
Hi @jason00111,
first of all, thanks for your first contribution to this project! 🎉 👍 🏅
I hope you'll like this project and enjoy hacking on it… 😃
This looks like a good contribution. Do you have a screenshot (or even better screencast) to see that it works as intended (with RTL languages and with LTR also still works)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
In LTR locales, the resize handle sits in the lower right of the popup. The right edge of the popup is fixed below the extension icon, so that edge can't move. When the handle is dragged, the popup grows from the left instead, which is disorienting.
Solution:
Move the resize handle to the lower left, so it's on the edge that actually moves.
Implementation:
The resize handle is a property of the textarea, and it is placed in the lower left automatically when the element's direction is RTL. We don't want to flip the direction on the textarea itself, since user-entered text should display in its natural reading direction.
So this PR:
direction: rtlon the body (so the handle ends up on the left).direction: __MSG_@@bidi_dir__on the body's children, so content still respects the user's locale.__MSG_@@bidi_dir__is copied from CommonCss.resizeMutationObserverto observe the body instead of the textarea, since the body is now what resizes.