Skip to content

test: add braze ecommerce recommended events coverage - #2646

Draft
rudder-devbox[bot] wants to merge 1 commit into
developfrom
harness/INT-7006-test-add-braze-ecommerce-recomm-1612dbf4
Draft

test: add braze ecommerce recommended events coverage#2646
rudder-devbox[bot] wants to merge 1 commit into
developfrom
harness/INT-7006-test-add-braze-ecommerce-recomm-1612dbf4

Conversation

@rudder-devbox

@rudder-devbox rudder-devbox Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Added Braze destination fixture cases for valid device-mode useEcommerceRecommendedEvents: true and invalid non-boolean values.
  • Added a focused validation assertion for the Braze UI field contract used as the source of truth for integrations-info mirroring.

Validation

  • npm ci — passed
  • pip3 install -r scripts/requirements.txt — passed
  • npm test -- --runTestsByPath test/validation.test.ts --watchAll=false — validation tests passed; command exited non-zero due scoped-run global coverage thresholds
  • npm test -- --runTestsByPath test/validation.test.ts --watchAll=false --coverage=false — passed
  • npx --prefix /workspace/rudder-integrations-config jest --runTestsByPath /workspace/rudder-integrations-config/test/validation.test.ts --watchAll=false --coverage=false --testNamePattern="exposes the feature-flagged field for cloud, device, and hybrid modes" --runInBand --silent — passed
  • PATH="/usr/local/bin:$PATH" npm run check:schema:destination -- braze — passed with existing schema-generator drift warnings
  • npx --prefix /workspace/rudder-integrations-config prettier --check /workspace/rudder-integrations-config/test/validation.test.ts /workspace/rudder-integrations-config/test/data/validation/destinations/braze.json — passed
  • npx --prefix /workspace/rudder-integrations-config eslint /workspace/rudder-integrations-config/test/validation.test.ts — passed
  • Integration verification: npx jest --runTestsByPath test/validation.test.ts --runInBand --silent=false --coverage=false — exit 0; 1 suite passed, 6041 tests passed

⚠️ Known Issues

  • The scoped Jest command without --coverage=false exits non-zero because this repo enforces 100% global coverage thresholds even though test/validation.test.ts passed.
  • Braze schema generation still reports pre-existing drift unrelated to useEcommerceRecommendedEvents: additionalProperties recommendation, missing app/platform key fields in generated schema expectations, consent-management required-field diffs, and required-field insertions for app/platform key fields.

Copilot AI lite review requested due to automatic review settings August 17, 2026 10:27
@rudder-devbox

rudder-devbox Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

👋 I'm rudder-devbox. I opened this PR from a Linear ticket.

Mention @devbox or @rudder-devbox and I'll act on it — on a top-level PR comment,
in a review summary, or on an inline comment on the diff. Without a mention I won't see it.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (211b7a4) to head (bd4d482).

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #2646   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          112       112           
  Branches        21        21           
=========================================
  Hits           112       112           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants