chore: cleanup AMP_vdm-next feature flag now that it is GA - #2432
Conversation
Remove AMP_vdm-next featureFlags prerequisite from fb_custom_audience and google_adwords_remarketing_lists ui-configs, and remove vdm-next feature entry from fb_custom_audience db-config. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis change removes feature flag configurations related to "vdm-next" from destination setup files for Facebook Custom Audience and Google Adwords Remarketing Lists, simplifying the conditional gating logic in these configurations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2432 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 102 102
Branches 21 21
=========================================
Hits 102 102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
AMP_vdm-nextfeatureFlags prerequisite fromfb_custom_audienceandgoogle_adwords_remarketing_listsui-configs — since the flag is GA (alwaystrue), thevalue: falsecheck was dead codevdm-nextfrom thefeaturesarray infb_custom_audiencedb-configTest plan
tiktok_audienceis untouched (flag not yet GA there)🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes