Skip to content

chore: cleanup AMP_vdm-next feature flag now that it is GA - #2432

Merged
shekhar-rudder merged 1 commit into
developfrom
int-6180-vdm-next-flag-cleanup
Apr 14, 2026
Merged

chore: cleanup AMP_vdm-next feature flag now that it is GA#2432
shekhar-rudder merged 1 commit into
developfrom
int-6180-vdm-next-flag-cleanup

Conversation

@shekhar-rudder

@shekhar-rudder shekhar-rudder commented Apr 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Remove AMP_vdm-next featureFlags prerequisite from fb_custom_audience and google_adwords_remarketing_lists ui-configs — since the flag is GA (always true), the value: false check was dead code
  • Remove vdm-next from the features array in fb_custom_audience db-config

Test plan

  • Verify the affected destination config pages (FB Custom Audience, Google Adwords Remarketing Lists) still render correctly in the UI
  • Confirm tiktok_audience is untouched (flag not yet GA there)

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated destination configuration settings for Facebook Custom Audience and Google Adwords Remarketing Lists by removing conditional feature flag entries.

Remove AMP_vdm-next featureFlags prerequisite from fb_custom_audience and
google_adwords_remarketing_lists ui-configs, and remove vdm-next feature
entry from fb_custom_audience db-config.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8eca9480-d89c-44be-82a3-6f2eba803642

📥 Commits

Reviewing files that changed from the base of the PR and between d119582 and ae04e72.

📒 Files selected for processing (3)
  • src/configurations/destinations/fb_custom_audience/db-config.json
  • src/configurations/destinations/fb_custom_audience/ui-config.json
  • src/configurations/destinations/google_adwords_remarketing_lists/ui-config.json
💤 Files with no reviewable changes (2)
  • src/configurations/destinations/fb_custom_audience/ui-config.json
  • src/configurations/destinations/fb_custom_audience/db-config.json

📝 Walkthrough

Walkthrough

This change removes feature flag configurations related to "vdm-next" from destination setup files for Facebook Custom Audience and Google Adwords Remarketing Lists, simplifying the conditional gating logic in these configurations.

Changes

Cohort / File(s) Summary
Facebook Custom Audience Configuration
src/configurations/destinations/fb_custom_audience/db-config.json, src/configurations/destinations/fb_custom_audience/ui-config.json
Removed "features": ["vdm-next"] entry from database config and stripped prerequisite feature flag condition (AMP_vdm-next: false) from UI config, leaving only basic connectionMode.cloud requirement.
Google Adwords Remarketing Lists Configuration
src/configurations/destinations/google_adwords_remarketing_lists/ui-config.json
Removed prerequisitesCondition: "or" and featureFlags array with AMP_vdm-next: false check from Schema Fields prerequisites block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Feature flags fade away like morning dew,
Vdm-next and amp-gates bid adieu,
Simpler configs, cleaner sight,
Destinations run just right! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description lacks critical required sections from the template including the related Linear task (Resolves INT-XXX), a comprehensive objectives section, and an incomplete developer checklist. Add the missing Linear task reference (Resolves INT-XXXX), complete the 'objectives of changes' section, and ensure the developer checklist is fully filled out before merging.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing the AMP_vdm-next feature flag cleanup from configuration files now that it has reached GA status.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch int-6180-vdm-next-flag-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@shekhar-rudder shekhar-rudder added the DO NOT MERGE Approved but need to check more label Apr 6, 2026
@codecov

codecov Bot commented Apr 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d119582) to head (ae04e72).
⚠️ Report is 16 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #2432   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          102       102           
  Branches        21        21           
=========================================
  Hits           102       102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shekhar-rudder shekhar-rudder removed the DO NOT MERGE Approved but need to check more label Apr 14, 2026
@shekhar-rudder
shekhar-rudder merged commit 0584aec into develop Apr 14, 2026
16 checks passed
@shekhar-rudder
shekhar-rudder deleted the int-6180-vdm-next-flag-cleanup branch April 14, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants