Ignore ENOENT when reading file annotations#121
Merged
martinemde merged 1 commit intomainfrom Mar 1, 2025
Merged
Conversation
ashleywillard
approved these changes
Feb 28, 2025
lib/code_ownership/private/ownership_mappers/file_annotations.rb
Outdated
Show resolved
Hide resolved
Errno::ENOENT is occuring intermittently for some users. This can happen even when the file seems to exist at the time. Since we were already returning quietly if a file did not exist, just try to read the file and rescue exceptions, returning silently. Fixes #98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errno::ENOENT is occuring intermittently for some users. This is happening even when the file seems to exist at the time
Since we were already returning quietly if a file did not exist, just try to read the file and rescue exceptions, returning silently.
Fixes #98