Skip to content

Use C as the delimiter for heredocs with C code#1726

Merged
st0012 merged 2 commits into
ruby:masterfrom
Earlopain:c-parser-heredocs
Jun 14, 2026
Merged

Use C as the delimiter for heredocs with C code#1726
st0012 merged 2 commits into
ruby:masterfrom
Earlopain:c-parser-heredocs

Conversation

@Earlopain

Copy link
Copy Markdown
Contributor

A sufficiently smart editor will then syntax-highlight them

Also dedent them while we're here.

A sufficiently smart editor will then syntax-highlight them

Also dedent them while we're here.
Copilot AI review requested due to automatic review settings June 12, 2026 18:37
@Earlopain Earlopain requested a deployment to fork-preview-protection June 12, 2026 18:37 — with GitHub Actions Waiting

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the RDoc C parser test fixtures to use squiggly heredocs for cleaner indentation while preserving the intended C source text.

Changes:

  • Replaced many <<-EOF / <<-'EOF' heredocs with <<~C / <<~'C' for consistent indentation stripping.
  • Normalized indentation of embedded C snippets and multi-line expected strings/comments in tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/rdoc/parser/c_test.rb Outdated
@Earlopain Earlopain temporarily deployed to fork-preview-protection June 12, 2026 18:41 — with GitHub Actions Inactive
@matzbot

matzbot commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

🚀 Preview deployment available at: https://feac2a1f.rdoc-6cd.pages.dev (commit: 110dbb8)

@st0012

st0012 commented Jun 14, 2026

Copy link
Copy Markdown
Member

Thanks!

@st0012 st0012 merged commit 54fa179 into ruby:master Jun 14, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants