fix(pnpm): allow flag-first args to pass through#681
Open
TechWizard9999 wants to merge 1 commit intortk-ai:developfrom
Open
fix(pnpm): allow flag-first args to pass through#681TechWizard9999 wants to merge 1 commit intortk-ai:developfrom
TechWizard9999 wants to merge 1 commit intortk-ai:developfrom
Conversation
fa9f944 to
a60dba5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes
rtk pnpmargument parsing for flag-first invocations so RTK no longer fails before passthrough can run.Commands like
rtk pnpm --filter mymodule testare now routed to nativepnpmsafely.Related Issue
Closes #259
Changes Made
rtk pnpmCLI parsing to accept raw pnpm args (instead of strict clap subcommands)list,outdated,install,typecheck)Testing
cargo fmt --all --checkrtk cargo clippy --all-targetsrtk cargo test --allrtk cargo run -- pnpm --filter mymodule test --help@aeppling please review when you have a moment.