Skip to content

fix(rewrite): route pnpm lint through rtk pnpm#678

Open
TechWizard9999 wants to merge 1 commit intortk-ai:developfrom
TechWizard9999:fix/rewrite-pnpm-lint-to-rtk-pnpm-lint
Open

fix(rewrite): route pnpm lint through rtk pnpm#678
TechWizard9999 wants to merge 1 commit intortk-ai:developfrom
TechWizard9999:fix/rewrite-pnpm-lint-to-rtk-pnpm-lint

Conversation

@TechWizard9999
Copy link

Description

Fixes rewrite routing for pnpm lint so it no longer gets forced into rtk lint (which can cause ESLint-oriented retry loops in non-ESLint projects).

Related Issue

Closes #665

Changes Made

  • updated discovery pattern matching so pnpm lint is recognized by the pnpm rule path
  • removed pnpm lint from rtk lint rewrite prefixes
  • added rewrite regression tests:
    • pnpm lint -> rtk pnpm lint
    • pnpm lint --fix -> rtk pnpm lint --fix
  • added changelog note under Unreleased bug fixes

Files Changed

Testing

  • cargo fmt --all --check
  • rtk cargo clippy --all-targets (2 pre-existing warnings in untouched files)
  • rtk cargo test
  • rtk cargo test discover::registry::tests::test_rewrite_pnpm_lint_routes_to_pnpm
  • rtk cargo test discover::registry::tests::test_rewrite_pnpm_lint_with_args_routes_to_pnpm
  • ./target/debug/rtk rewrite "pnpm lint" -> rtk pnpm lint

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Documentation updated
  • No breaking changes introduced

cc @pszymkowiak for review

Signed-off-by: Roopesh <roopesh1724989@gmail.com>
@TechWizard9999 TechWizard9999 force-pushed the fix/rewrite-pnpm-lint-to-rtk-pnpm-lint branch from c7d146e to 1b17d79 Compare March 19, 2026 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant