fix(rewrite): route pnpm lint through rtk pnpm#678
Open
TechWizard9999 wants to merge 1 commit intortk-ai:developfrom
Open
fix(rewrite): route pnpm lint through rtk pnpm#678TechWizard9999 wants to merge 1 commit intortk-ai:developfrom
TechWizard9999 wants to merge 1 commit intortk-ai:developfrom
Conversation
Signed-off-by: Roopesh <roopesh1724989@gmail.com>
c7d146e to
1b17d79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes rewrite routing for
pnpm lintso it no longer gets forced intortk lint(which can cause ESLint-oriented retry loops in non-ESLint projects).Related Issue
Closes #665
Changes Made
pnpm lintis recognized by thepnpmrule pathpnpm lintfromrtk lintrewrite prefixespnpm lint->rtk pnpm lintpnpm lint --fix->rtk pnpm lint --fixFiles Changed
src/discover/rules.rs- rewrite/classification adjustmentssrc/discover/registry.rs- regression tests for pnpm lint rewrite behaviorCHANGELOG.md- unreleased bug-fix note for pnpm lint causing issue when ESLint isn't used #665Testing
cargo fmt --all --checkrtk cargo clippy --all-targets(2 pre-existing warnings in untouched files)rtk cargo testrtk cargo test discover::registry::tests::test_rewrite_pnpm_lint_routes_to_pnpmrtk cargo test discover::registry::tests::test_rewrite_pnpm_lint_with_args_routes_to_pnpm./target/debug/rtk rewrite "pnpm lint"->rtk pnpm lintChecklist
cc @pszymkowiak for review