feat: add search,project and approval status filters to get_timesheet…#899
Open
wreckage0907 wants to merge 3 commits intoversion-16-hotfixfrom
Open
feat: add search,project and approval status filters to get_timesheet…#899wreckage0907 wants to merge 3 commits intoversion-16-hotfixfrom
wreckage0907 wants to merge 3 commits intoversion-16-hotfixfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the get_timesheet_data timesheet API to support additional filtering (search term, project(s), and approval status), and adjusts internal retrieval logic to apply these filters while avoiding cached results when filters are active.
Changes:
- Added
search,project, andapproval_statusparameters toget_timesheet_data, including JSON parsing for list-like inputs. - Added approval-status filtering at the week aggregation layer and passed filter state into week generation.
- Extended
get_timesheetto accept afiltersargument and apply project/search filtering to returned task/log data.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds enhanced filtering capabilities to the timesheet API, allowing users to filter timesheet data based on search terms, project(s), and approval status. The changes improve both the API interface and the internal data retrieval logic to support these new filters.
Relevant Technical Choices
get_timesheet_datafunction now acceptssearch,project, andapproval_statusparameters, parsing them as JSON lists when needed and building a unified filters dictionary.get_timesheetfunction now accepts afiltersargument and applies project filtering at both the parent timesheet and detail levels.Testing Instructions
Additional Information:
Screenshot/Screencast
Checklist
closes #904