Add missing user name field in Sales partner#79
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a missing user name field to the Sales Partner doctype. The field is configured to automatically fetch the username from the associated user record.
Changes:
- Added
custom_user_namefield to Sales Partner with fetch fromcustom_user.username - Updated Sales Partner field order to include the new user name field
- Reordered multiple custom field definitions (JSON formatting)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frappe_affiliate/fixtures/property_setter.json | Adds field_order property setter for Sales Partner including custom_user_name |
| frappe_affiliate/fixtures/custom_field.json | Adds custom_user_name field definition for Sales Partner with auto-fetch configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a178cb8 to
be5c8d7
Compare
be5c8d7 to
d837f49
Compare
Aryan20
approved these changes
Jan 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.