This repository was archived by the owner on Oct 23, 2022. It is now read-only.
Open
Conversation
The IPFS facade does not have access to the functions which add and remove nodes to the floodsub target_peer list. As such, messages are never propagated to connected peers.
8f27c49 to
39c4f16
Compare
Collaborator
|
Hi @cobward! Thanks for the PR. I've missed this, and now that libp2p was upgraded to 0.43 in #499 I think this is handled "automatically". Could you check and see if the automation matches what you are after? My initial understanding is that this is something which should be handled behind the scenes and not be exposed, and I don't think this is exposed in go-ipfs (http api at least). I have to admit I'm not up to speed on topic discovery for gossipsub/floodsub, and doubt the partial view adding done with the upgrade is enough for that. If you know more of this topic, any help would be welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IPFS facade does not have access to the functions which add and remove nodes to the floodsub target_peer list. As such, messages are never propagated to connected peers.
This PR adds two methods to the IPFS facade so that these functions can be used, and so that pubsub can be used in a network of more than one IPFS peer.
Checklist (can be deleted from PR description once items are checked)