hMailServer password changer (db version)#9842
hMailServer password changer (db version)#9842AndreaLanfranchi wants to merge 3 commits intoroundcube:masterfrom
Conversation
| $data = $stmt->fetch(PDO::FETCH_ASSOC); | ||
|
|
||
| if (!$data) { | ||
| return PASSWORD_COMPARE_CURRENT; |
There was a problem hiding this comment.
It would be good to log an error in this case.
There was a problem hiding this comment.
Yes that'd be nice.
You mean by usage of raise_error ?
(Sorry I'm not completely familiar with this codebase)
|
To follow this PR. |
|
Also I'd like to ask ... wouldn't be better to logoff user account after a succesful password change ? |
No. |
|
I've noted some coding style issues. And I'm wondering why tests aren't triggered for this PR. |
|
@AndreaLanfranchi: Any progress on it? |
Honestly been focused on other things. |
|
@AndreaLanfranchi: Thanks for your answer, have you progressed? |
3 participants
This PR implements the password change feature for hMailServer with direct read/write onto hMailServer database (mySQL only). This has been made possible by the availability of public source code for hMailServer.
Although old and no longer maintained hMailServer might still have quite a few installations active and running (I use it for personal purposes). Hope their sysops find this new plugin useful.
Warning: Unlike the hmail password plugin (DCOM), this plugin does not use the hmailserver COM object to change the password. As a result while the password is correctly changed in the database, hMailServer's process will not be notified of the change and, as a result, will not close the active connections bound to the current address. This means that the new password will not be used until the same address does re-autheticate on each protocol (SMTP/IMAP/PO3).
Comments and further hints are welcome.