Add conda (formerly: RoboStack) platform#1018
Add conda (formerly: RoboStack) platform#1018baszalmstra wants to merge 4 commits intoros-infrastructure:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1018 +/- ##
==========================================
+ Coverage 71.76% 72.21% +0.45%
==========================================
Files 44 45 +1
Lines 3488 3513 +25
Branches 686 688 +2
==========================================
+ Hits 2503 2537 +34
+ Misses 808 798 -10
- Partials 177 178 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/rosdep2/gbpdistro_support.py
Outdated
| # Do generation for conda entries | ||
| # conda package naming follows debian convention: ros-{release}-{package} | ||
| conda_package_name = 'ros-%s-%s' % (release_name, pkg) | ||
| conda_package_name = conda_package_name.replace('_', '-') | ||
| rosdep_data[pkg][OS_CONDA] = { | ||
| CONDA_INSTALLER: {'packages': [conda_package_name]} | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm pretty sure we won't need this. gbpdistro hasn't been used since ROS Fuerte.
src/rosdep2/platforms/conda.py
Outdated
| def conda_detect(packages): | ||
| # Return empty list - no packages detected as installed | ||
| # This is a stub implementation for package mapping only | ||
| return [] |
There was a problem hiding this comment.
This is a pretty good way to handle this for now, but what would the behavior look like if we raised NotImplementedError instead?
There was a problem hiding this comment.
Changed it for now, it shouldn't really matter but not atleast it's more clear at runtime.
Co-authored-by: Scott K Logan <[email protected]>
|
Sorry we lost sight of this PR, I processed all comments. Would you be able to rereview @cottsay? |
3 participants
This is a continuation of #810.
The scope of #810 has been trimmed down after a discussion with @cottsay and @traversaro . This PR only adds the necessary constants and machinery to add conda as a supported rosdep mapping. I based this mostly on the original PR and the nix implementation.
@traversaro, I wasn't sure if you wanted to rename some keys?