Support reinstall in check command#1001
Open
krisl wants to merge 17 commits intoros-infrastructure:masterfrom
Open
Support reinstall in check command#1001krisl wants to merge 17 commits intoros-infrastructure:masterfrom
krisl wants to merge 17 commits intoros-infrastructure:masterfrom
Conversation
0f7160d to
a3f989d
Compare
This reverts commit 1aa399ccba49a8d7f43a5f267c990a5cae17a1f8.
This reverts commit 12ab29b28fef5564399cf3120ace9c91e377b649.
This reverts commit 545748c588214666aa039a0f5bfae15b4a43dbdb.
make check command report like install
a3f989d to
b7dec8e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1001 +/- ##
==========================================
+ Coverage 71.76% 72.43% +0.67%
==========================================
Files 44 44
Lines 3488 3483 -5
Branches 686 684 -2
==========================================
+ Hits 2503 2523 +20
+ Misses 808 785 -23
+ Partials 177 175 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--reinstallsupport also for thecheckcommand, so we can get a full list of deps.Useful for things like CI and packaging where you want to spit out all dependencies to do something with them later on.
Additionally adds some consistency in output between commands.