Skip to content

added drawing to explain the new data_flow in urdf - #591

Open
Simon248 wants to merge 1 commit into
ros-industrial:melodic-devel-stagingfrom
Simon248:update_readme_for_melodic_staging
Open

added drawing to explain the new data_flow in urdf#591
Simon248 wants to merge 1 commit into
ros-industrial:melodic-devel-stagingfrom
Simon248:update_readme_for_melodic_staging

Conversation

@Simon248

@Simon248 Simon248 commented Sep 29, 2021

Copy link
Copy Markdown

Related to issue Documentation: ur_description package structure #539

added drawing in readme
added jpg of drawing in repo
added drawio file in rep (if evolution are needed, can be open in https://app.diagrams.net/)

@NadiaHG

NadiaHG commented Sep 29, 2021

Copy link
Copy Markdown
Member

@Simon248 thanks a lot for your contribution, it is a really nice addition to the documentation of this package.

I would suggest to move the draw to the package ur_description. A READMEmd file can also be added to the folder package to add some text with the context and include the diagram to preview it on GitHub.

@NadiaHG NadiaHG linked an issue Sep 29, 2021 that may be closed by this pull request
Documentation: ur_description package structure #539
Open
@NadiaHG NadiaHG added the wrid21 label Sep 29, 2021
@lianghongzhuo

lianghongzhuo commented Sep 30, 2021 •
edited
Loading

Copy link
Copy Markdown

Thanks for your drawing. It would be better for visualization if you can use SVG file format, as it is scalable and GitHub supports rendering SVG files in the markdown preview.

@Simon248
Simon248 force-pushed the update_readme_for_melodic_staging branch from 511fef9 to a1564d6 Compare October 21, 2021 12:12
simon
added drawing to explain the new data_flow in urdf
e35584f 
change diagramme to svg and moved diagramme in ur_description packages

update visual in urdf_data_flow.svg

Delete urdf_data_flow.drawio.svg:Zone.Identifier

supress useless file

Delete urdf_data_flow.svg:Zone.Identifier

supress useless file

supress JPG

add description in readme
@Simon248
Simon248 force-pushed the update_readme_for_melodic_staging branch from a1564d6 to e35584f Compare October 21, 2021 12:31
@Simon248

Simon248 commented Oct 21, 2021

Copy link
Copy Markdown
Author

Hi,

@ipa-nhg Thanks for the feedback, modifications done.

@fmauch fmauch added this to the melodic-devel-staging milestone Nov 7, 2022
@RobertWilbrandt

RobertWilbrandt commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

Hey, thanks for the contribution. I think the image contains only one error: The ur_macro.xacro file is also in the inc subdirectory. Could you adjust that?

As this is only a documentation change i would not see this as blocking #617 and therefore not put it in the milestone.

@RobertWilbrandt RobertWilbrandt removed this from the melodic-devel-staging milestone Nov 8, 2022
@fmauch fmauch modified the milestone: melodic-devel-staging Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation: ur_description package structure

6 participants

@Simon248 @NadiaHG @lianghongzhuo @RobertWilbrandt @fmauch @gavanderhoorn