Add transmission_hw_interface to URe xacro and expose everywhere - #528
Open
pcw109550 wants to merge 1 commit into
Open
Add transmission_hw_interface to URe xacro and expose everywhere#528pcw109550 wants to merge 1 commit into
pcw109550 wants to merge 1 commit into
Conversation
NadiaHG
approved these changes
Jul 14, 2020
Member
There was a problem hiding this comment.
Thanks a lot for this contribution, I think the changes make sense for this branch and for consistency with #392 .
(Comment: the current version of this repository (for melodic), which have common launch files for both UR series, supports already this feature: https://github.com/ros-industrial/universal_robot/blob/melodic-devel-staging/ur_gazebo/launch/inc/load_ur.launch.xml#L28)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the capability to select the hardware interface used in the
<transmission>elements in the URDF model. This allows creating custom simulation setups with different hardware interfaces, e.g.hardware_interface/VelocityJointInterface.Same changes compared with #392, applying to all URe models in this case.