Open
Conversation
Update link list and joint list parameter to matched ABB IRB6660_100_330 data
Upload all 3 vairiances moveit config
…_experimental.git into feature/irb6660
kinneyjustin
approved these changes
May 8, 2019
kinneyjustin
approved these changes
May 8, 2019
kinneyjustin
approved these changes
May 8, 2019
kinneyjustin
approved these changes
May 8, 2019
kinneyjustin
previously approved these changes
May 8, 2019
cjue
reviewed
Aug 31, 2022
Contributor
cjue
left a comment
cjue
left a comment
There was a problem hiding this comment.
From my view this PR still needs some changes.
| @@ -1,4 +0,0 @@ | |||
| cmake_minimum_required(VERSION 2.8.3) | |||
Contributor
There was a problem hiding this comment.
These two abb_experimenal/ files should not be deleted.
| <!-- | ||
| Manipulator specific version of the state visualizer. | ||
|
|
||
| Defaults provided for irb_6650s_90: |
Contributor
There was a problem hiding this comment.
wrong robot model here and in the usage line
| @@ -0,0 +1,11 @@ | |||
| moveit_setup_assistant_config: | |||
Contributor
There was a problem hiding this comment.
As moveit configs are usually application dependant they should probably not be part of this pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding irb6660 (and variants) support and moveit config