Skip to content

test: add tests for duplicate prevention (fixes #2952)#3189

Open
kamal2730 wants to merge 1 commit intoros-controls:masterfrom
kamal2730:testcase/duplicate_entries
Open

test: add tests for duplicate prevention (fixes #2952)#3189
kamal2730 wants to merge 1 commit intoros-controls:masterfrom
kamal2730:testcase/duplicate_entries

Conversation

@kamal2730
Copy link
Copy Markdown

Add tests for PR #2951 - duplicate entries fix in controller exported interfaces. This adds tests for both reference and state interfaces to ensure that calling make_controller_reference_interfaces_available() and make_controller_exported_state_interfaces_available() multiple times does not create duplicate entries.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

Add tests for PR ros-controls#2951 - duplicate entries fix in controller exported interfaces.
This adds tests for both reference and state interfaces to ensure that
calling make_controller_reference_interfaces_available() and
make_controller_exported_state_interfaces_available() multiple times does
not create duplicate entries.
- Extended managing_controllers_reference_interfaces with duplicate prevention test
- Added new managing_controllers_state_interfaces test with duplicate prevention
- Both tests verify no duplicates are created when making interfaces available
  multiple times (simulating multiple activate calls)
Fixes: ros-controls#2952
See-also: ros-controls#2951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests for the duplicate entries in the controller exported interfaces

1 participant