test: add tests for duplicate prevention (fixes #2952)#3189
Open
kamal2730 wants to merge 1 commit intoros-controls:masterfrom
Open
test: add tests for duplicate prevention (fixes #2952)#3189kamal2730 wants to merge 1 commit intoros-controls:masterfrom
kamal2730 wants to merge 1 commit intoros-controls:masterfrom
Conversation
Add tests for PR ros-controls#2951 - duplicate entries fix in controller exported interfaces. This adds tests for both reference and state interfaces to ensure that calling make_controller_reference_interfaces_available() and make_controller_exported_state_interfaces_available() multiple times does not create duplicate entries. - Extended managing_controllers_reference_interfaces with duplicate prevention test - Added new managing_controllers_state_interfaces test with duplicate prevention - Both tests verify no duplicates are created when making interfaces available multiple times (simulating multiple activate calls) Fixes: ros-controls#2952 See-also: ros-controls#2951
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for PR #2951 - duplicate entries fix in controller exported interfaces. This adds tests for both reference and state interfaces to ensure that calling make_controller_reference_interfaces_available() and make_controller_exported_state_interfaces_available() multiple times does not create duplicate entries.
See-also: Fix the duplicate entries in the controller exported interfaces #2951
To send us a pull request, please:
colcon testandpre-commit run(requires you to install pre-commit bypip3 install pre-commit)