Removed deprecated standalone thread_priority variable

[gatetub]

Description

This Pull Request completes the planned removal of the standalone thread_priority variable from the HardwareInfo struct, as part of the migration to the nested async_params structure.

Related Issue: Fixes #3160

Changes:

• Core Logic: Removed deprecated standalone int thread_priority from HardwareInfo.
• Parser Updates: Updated component_parser.cpp to remove deprecated #ifdef blocks.
• Controller Base: Cleaned up controller_interface_base.cpp parameter declarations.
• Test Assets: Updated descriptions.hpp and verified existing tests in test_component_parser.cpp.

Verification:

• Performed a clean build using colcon build --packages-up-to hardware_interface controller_interface on the master branch.
• Verified that all local tests pass and the pipeline is expected to be green.

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
2. Give your PR a descriptive title. Add a short summary, if required.
3. Make sure the pipeline is green.
4. Don’t be afraid to request reviews from maintainers.
5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

• Fork the repository.
• Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
• Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
• Commit to your fork using clear commit messages.
• Send a pull request, answering any default questions in the pull request interface.
• Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

[gatetub]

This is my first contribution to ros2_control! I have updated the PR to target the master branch as requested and verified the build locally. I've also run pre-commit to ensure the formatting matches the project standards.

I would appreciate a review when you have a moment, and I'm happy to make any further adjustments needed. Thanks for the guidance! @christophfroehlich

[christophfroehlich]

Thanks for your first contribution. Please consider the comments and revise the changes.

[christophfroehlich]

where do these changes come from?

Please revise the changes, we only want to remove the deprecated variable and its usage.

[gatetub]

will changes be made to hardware_interface/include/hardware_interface/hardware_info.hpp only ? presence of thread_priority in rest files remain unchanged?

[christophfroehlich]

I suggest removing the member variable, and go through the build errors where this variable was used ;) Please remove all the deprecation-silencing preprocessor macros added with #2644