Refactor launch test to use launch substitutions instead of os#3142
Open
AdvityaCode wants to merge 3 commits intoros-controls:masterfrom
Open
Refactor launch test to use launch substitutions instead of os#3142AdvityaCode wants to merge 3 commits intoros-controls:masterfrom
AdvityaCode wants to merge 3 commits intoros-controls:masterfrom
Conversation
Merging changes into my fork
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3142 +/- ##
=======================================
Coverage 89.35% 89.35%
=======================================
Files 158 158
Lines 19392 19388 -4
Branches 1573 1573
=======================================
- Hits 17327 17324 -3
+ Misses 1419 1418 -1
Partials 646 646
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
christophfroehlich
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Difference from PR #2789: Another attempt used PathSubstitution (for single path segments) rather than PathJoinSubstitution (for joining multiple path parts), which caused CI failures.
Can you point me to the failing CI? This should work?
The rest LGTM.
Contributor
|
This pull request is in conflict. Could you fix it @AdvityaCode? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2767
Replaces os-based path construction with proper ROS 2 launch substitutions in test_ros2_control_node_launch.py and updates the outdated example in the launch_utils.py docstring.
Changes:
Difference from PR #2789:
Another attempt used PathSubstitution (for single path segments) rather than PathJoinSubstitution (for joining multiple path parts), which caused CI failures. This PR also removes the with open(urdf) file-reading block entirely — replacing it with a Command(["cat ", ...]) substitution that is evaluated lazily at launch time rather than eagerly at description-generation time. The docstring fix requested by @christophfroehlich in this comment is also included.