Add 6D robot description to ros2_control_test_assets#3032
Add 6D robot description to ros2_control_test_assets#3032naitikpahwa18 wants to merge 3 commits intoros-controls:masterfrom
Conversation
Signed-off-by: Naitik Pahwa <naitikpahwa18@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds a new reusable test asset header to ros2_control_test_assets that provides a 6-DOF robot URDF and matching SRDF as embedded string constants, intended for reuse across multiple controller test suites.
Changes:
- Added
test_asset_6d_robot_description.hppcontainingvalid_6d_robot_urdfandvalid_6d_robot_srdfstring assets.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ros2_control_test_assets/include/ros2_control_test_assets/test_asset_6d_robot_description.hpp
Outdated
Show resolved
Hide resolved
ros2_control_test_assets/include/ros2_control_test_assets/test_asset_6d_robot_description.hpp
Outdated
Show resolved
Hide resolved
…_asset_6d_robot_description.hpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Naitik Pahwa <naitikpahwa18@users.noreply.github.com>
destogl
left a comment
There was a problem hiding this comment.
I think we should switch to another robot description that we are using in the ros2_control_demos. Here it is: https://github.com/ros-controls/ros2_control_demos/tree/master/ros2_control_demo_description/r6bot
@christophfroehlich, @bmagyar and @saikishor should we copy this description or move it here and then reference it always from test assets? Or is maintaining two copies OK in this case?
| @@ -0,0 +1,308 @@ | |||
| // Copyright (c) 2021, Stogl Robotics Consulting UG (haftungsbeschränkt) | |||
There was a problem hiding this comment.
| // Copyright (c) 2021, Stogl Robotics Consulting UG (haftungsbeschränkt) | |
| // Copyright (c) 2021, b»robotized group |
Description
Adds
test_asset_6d_robot_description.hpptoros2_control_test_assetspackage to make it reusable across multiple controllers.Related Issues
Part of fix for ros-controls/ros2_controllers#450
Additional context
This PR should be merged in coordination with the ros-controls/ros2_controllers#2173