[ntuple] add test for ShiftAliasColumn xHeader patch-up#22747
Open
silverweed wants to merge 1 commit into
Open
[ntuple] add test for ShiftAliasColumn xHeader patch-up#22747silverweed wants to merge 1 commit into
silverweed wants to merge 1 commit into
Conversation
6 tasks
Test Results 23 files 23 suites 3d 18h 32m 16s ⏱️ Results for commit 7c61e59. ♻️ This comment has been updated with latest results. |
jblomer
reviewed
Jul 6, 2026
jblomer
left a comment
jblomer
left a comment
Contributor
There was a problem hiding this comment.
In principle OK but slightly confusing because the alias columns of the projected field, in a real descriptor, would evolve in lock-step with their origin columns / field.
silverweed
force-pushed
the
ntuple_test_shift_alias
branch
from
60058e6 to
e3211a2
Compare
Contributor
Author
|
@jblomer I updated the test to a more realistic scenario |
Testing the change introduced in d32b64c
silverweed
force-pushed
the
ntuple_test_shift_alias
branch
from
e3211a2 to
7c61e59
Compare
jblomer
approved these changes
Jul 8, 2026
|
|
||
| // We are about to add a new physical column, so we need to shift the already-existing alias column. | ||
| builder.ShiftAliasColumns(1); | ||
| builder.AddColumn(RColumnDescriptorBuilder() |
Contributor
There was a problem hiding this comment.
Perhaps add a comment that a real descriptor would also add the corresponding alias column for pt_proj.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the change introduced in d32b64c
The situation to test is: