Skip to content

[RDF][Docs] Group the RInterface API in doxygen into Actions / Transformations / General#22320

Merged
hageboeck merged 2 commits into
root-project:masterfrom
hageboeck:rdf_interfaceGrouping
Jun 24, 2026
Merged

[RDF][Docs] Group the RInterface API in doxygen into Actions / Transformations / General#22320
hageboeck merged 2 commits into
root-project:masterfrom
hageboeck:rdf_interfaceGrouping

Conversation

@hageboeck

@hageboeck hageboeck commented May 18, 2026

Copy link
Copy Markdown
Member

Group the RDataFrame interface in the doxygen overview. This results in a structure like this:

| image | image | image |

@hageboeck hageboeck self-assigned this May 18, 2026
@github-actions

github-actions Bot commented May 18, 2026

Copy link
Copy Markdown

Test Results

    21 files      21 suites   3d 11h 40m 0s ⏱️
 3 870 tests  3 870 ✅ 0 💤 0 ❌
73 626 runs  73 626 ✅ 0 💤 0 ❌

Results for commit 2d364a1.

♻️ This comment has been updated with latest results.

@vepadulano vepadulano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I have left some comments only related to the last commit.

Comment thread tree/dataframe/inc/ROOT/RDF/RInterface.hxx
Comment thread tree/dataframe/inc/ROOT/RDF/RInterface.hxx
Comment thread tree/dataframe/inc/ROOT/RDF/RInterface.hxx
Comment thread tree/dataframe/inc/ROOT/RDF/RInterface.hxx Outdated
Comment thread tree/dataframe/inc/ROOT/RDF/RInterface.hxx Outdated
Comment thread tree/dataframe/inc/ROOT/RDF/RInterface.hxx Outdated
@hageboeck hageboeck force-pushed the rdf_interfaceGrouping branch 2 times, most recently from 452f04d to 2fe579f Compare May 20, 2026 11:20
@hageboeck hageboeck marked this pull request as ready for review May 20, 2026 11:33
@hageboeck hageboeck requested a review from martamaja10 as a code owner May 20, 2026 11:33
@hageboeck hageboeck force-pushed the rdf_interfaceGrouping branch from 2fe579f to f07dc90 Compare May 20, 2026 11:37

@vepadulano vepadulano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice thanks! Let's wait for the CI to finish before merging

Create groups for transformations and actions. This makes it easier to
look at the RDF interface at a glance, because base-class functions are
inlined in the list of functions.
This required reordering of the code, but this is an NFC.
@hageboeck hageboeck force-pushed the rdf_interfaceGrouping branch from f07dc90 to 2d364a1 Compare June 23, 2026 11:59
@hageboeck hageboeck added the skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff. label Jun 23, 2026
@hageboeck hageboeck merged commit 39a2e3b into root-project:master Jun 24, 2026
35 of 37 checks passed
@hageboeck hageboeck deleted the rdf_interfaceGrouping branch June 24, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants