Fix --block-size being ignored in ronin encrypt/decrypt#281
Open
gillisd wants to merge 1 commit into
Open
Conversation
process_input referenced @block_size which does not exist as an instance variable on CipherCommand, so it evaluated to nil. This caused cipher.stream to call io.read(nil) which reads the entire input into memory at once instead of streaming in chunks. Changed to options[:block_size] to read the actual CLI option value. Also added specs for Encrypt#process_input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--block-sizeoption ofronin encrypt/ronin decryptis silently ignored. Theprocess_inputmethod references@block_size, an instance variable that does not exist onCipherCommand. It evaluates tonil, causingcipher.streamto callio.read(nil)which reads the entire input into memory at once instead of streaming in chunks.This PR adds specs for
Encrypt#process_inputand fixes the reference to useoptions[:block_size], so the CLI flag actually takes effect.