Conversation
|
@edshot99 is attempting to deploy a commit to the rollup-js Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
Thanks. It appears this build actually works!
In order to release this, though, a few more things need to be fixed. Cf. also what is done in #6163, even though that one does not build:
- build-openbsd needs to become a dependency of the publish job
- build-openbsd references several matrix properties that do not exist. I would just hard-code those in the right places:
- matrix.settings.cache-cargo: Unless there it does not work, we always want to cache as it is a massive performance improvement
- matrix.settings.host: Not important to have in the cache key
- you need to add the new triple to the main package.json file
- do we need any of the Rust changes done in #6163?
- replace missing matrix settings with hardcodes - make test job depend on build-openbsd - added missing triplet to package.json
|
Everything should be fixed now.
The amd64 build could be switched to use mimalloc (if tested), but I prefer to stick with the native memory allocator which doesn't require any Rust changes. As for the #6163 PR, Claude AI assumes that OpenBSD arm64 will have the same SIGILL issues that Linux and Android arm64 had which is why it made changes to the Rust files to exclude it from using mimalloc. |
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
The build looks fine so far, thanks!
This should help NAPI-RS to properly identify the artifact
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6224 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 272 272
Lines 10720 10720
Branches 2870 2870
=======================================
Hits 10593 10593
Misses 85 85
Partials 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
This PR contains:
OpenBSD amd64 support
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
I added support for OpenBSD to wasm-pack since rollup has a dependency on it. Installing rollup with the updated wasm-pack gives no issues.
wasm-pack, however, cannot be used without a Rust wasm32-unknown-unknown compiler. I tried to compile one with a patch from the ports@ list, but it doesn't seem to work anymore. Following the instructions to use a prebuilt wasm32 compiler from the Rust repos somwhat works, but has issues when being used with rollup.
For napi/native builds everything works fine. OpenBSD 7.7 support is not included since the Rust compiler is too old. Only amd64 support was included since I can verify it works.
The npm packages will be in the format of openbsdX.X-arch since binaries can or will be incompatible between OpenBSD versions.