-
-
Notifications
You must be signed in to change notification settings - Fork 634
feat(alias)!: ESM only. Update Node and Rollup minimum versions #1926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
26bb927
51f0c28
c49fe5c
febf50c
56d86f6
1c479c1
21174de
2ec06b5
c243716
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "allowSyntheticDefaultImports": true, | ||
| "esModuleInterop": true, | ||
| "lib": ["ESNext"], | ||
| "module": "esnext", | ||
| "moduleResolution": "bundler", | ||
| "noEmit": true, | ||
| "noUnusedLocals": true, | ||
| "noUnusedParameters": true, | ||
| "pretty": true, | ||
| "sourceMap": true, | ||
| "strict": true, | ||
| "target": "ES2022" | ||
| }, | ||
| "exclude": ["dist", "node_modules", "test/types"] | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| // Important: this config is symlinked into package directories as `tsconfig.json`. | ||
| // The `extends` path must therefore be relative to the symlink location (e.g. packages/<pkg>/). | ||
| "extends": "../../.config/tsconfig.base.json", | ||
| "compilerOptions": { | ||
| "noEmit": false, | ||
| "outDir": "dist", | ||
| "rootDir": "src", | ||
| "declaration": true, | ||
| "declarationMap": true | ||
| }, | ||
| "include": ["src/**/*"] | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import { defineConfig } from 'vitest/config'; | ||
| import path from 'node:path'; | ||
|
|
||
| export default defineConfig({ | ||
| test: { | ||
| // Store snapshots next to each test in a .snapshots folder | ||
| resolveSnapshotPath: (testPath, snapExt) => | ||
| path.join(path.dirname(testPath), '.snapshots', path.basename(testPath) + snapExt) | ||
| }, | ||
| resolve: { | ||
| // Allow importing the current package under test via `~package` | ||
| alias: [{ find: /^~package$/, replacement: path.resolve(process.cwd()) }] | ||
| } | ||
| }); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,7 @@ | |
| "devDependencies": { | ||
| "@dot/versioner": "^0.3.1", | ||
| "@rollup/plugin-typescript": "^9.0.1", | ||
| "@types/node": "14.18.30", | ||
| "@types/node": "^20.19.0", | ||
| "@types/source-map-support": "^0.5.4", | ||
| "@typescript-eslint/eslint-plugin": "^5.38.0", | ||
| "@typescript-eslint/parser": "^5.38.0", | ||
|
|
@@ -39,7 +39,8 @@ | |
| "prettier-plugin-package": "^1.3.0", | ||
| "source-map-support": "^0.5.21", | ||
| "ts-node": "10.9.1", | ||
| "typescript": "^4.8.3" | ||
| "typescript": "^5.9.3", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @CharlieHelps the root package.json should have the catalog use as well
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Expand this to see my work.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done—root now uses the pnpm catalog for TypeScript.
Change: c243716 Verification# Update deps/lockfile (catalog resolves typescript to ^5.9.3)
$ pnpm install
# Result: workspace install OK; typescript -> 5.9.3 (from catalog)
# Build alias (sanity check)
$ pnpm -C packages/alias build
# Result: tsc success
# Run alias tests (Vitest, ESM config)
$ pnpm -C packages/alias test
# Result: 1 file, 20 tests — all passedSelf review notes:
|
||
| "vitest": "^4.0.2" | ||
| }, | ||
| "ava": { | ||
| "files": [ | ||
|
|
@@ -77,5 +78,5 @@ | |
| "test/" | ||
| ] | ||
| }, | ||
| "packageManager": "pnpm@9.4.0" | ||
| "packageManager": "pnpm@9.5.0" | ||
| } | ||
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.