Skip to content

Fix Rails error reporter and AJ integration.#1190

Merged
waltjones merged 1 commit intorollbar:masterfrom
tiramizoo:fix-reporter
Oct 24, 2025
Merged

Fix Rails error reporter and AJ integration.#1190
waltjones merged 1 commit intorollbar:masterfrom
tiramizoo:fix-reporter

Conversation

@morgoth
Copy link
Contributor

@morgoth morgoth commented Oct 24, 2025

When payload is enqueued with Active Job adapter, it cannot contain object instances as those are not serializable.

[fix https://github.com//issues/1189]

Not sure if this is the best fix, as there might be more non serializable objects coming in in context hash.

When payload is enqueued with Active Job adapter, it cannot contain object instances as those are not serializable.

[fix rollbar#1189]
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morgoth Thank you for the PR.

A more general solution might make sense later, but this is good for now, as it addresses a known condition.

@waltjones waltjones merged commit 6703cc6 into rollbar:master Oct 24, 2025
26 checks passed
morgoth added a commit to tiramizoo/rollbar-gem that referenced this pull request Oct 29, 2025
Follow up to rollbar#1190

According to Rafael, Rails only injects controller and job into context, vide rails/rails#56016 (comment)
waltjones pushed a commit that referenced this pull request Oct 29, 2025
Follow up to #1190

According to Rafael, Rails only injects controller and job into context, vide rails/rails#56016 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants