Skip to content

Add opaque, prim, and symb attributes to constant nodes#165

Merged
ybertot merged 1 commit intorocq-community:coq-masterfrom
JasonGross:attrib-opaque
Feb 6, 2026
Merged

Add opaque, prim, and symb attributes to constant nodes#165
ybertot merged 1 commit intorocq-community:coq-masterfrom
JasonGross:attrib-opaque

Conversation

@JasonGross
Copy link
Member

  • OpaqueDef constants get opaque=yes, body=yes
  • Def constants get opaque=no, body=yes
  • Undef constants get opaque=yes, body=no
  • Primitive constants get prim=yes, body=no (no opaque)
  • Symbol constants get symb=yes, body=no (no opaque)

I am mostly interested in the opaque attribute, and figured I'd add the other ones along side it.

Update all test oracle files and README documentation.

🤖 Generated with Claude Code

- OpaqueDef constants get opaque=yes, body=yes
- Def constants get opaque=no, body=yes
- Undef constants get opaque=yes, body=no
- Primitive constants get prim=yes, body=no (no opaque)
- Symbol constants get symb=yes, body=no (no opaque)

Update all test oracle files and README documentation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ybertot
Copy link
Collaborator

ybertot commented Feb 6, 2026

Thanks for this contribution. In a way, this reduces the need for PR #168, because once we extract a graph with opaque nodes marked as such, the behavior of generating a graph where opaque nodes are not traversed could be performed by post-processing.

@ybertot
Copy link
Collaborator

ybertot commented Feb 6, 2026

The fact that you used Claude to produce the code is irrelevant, as was already mentioned in a comment for another pull request. Even more so in this case because the amount of code actually written for this patch is minute.

Copy link
Collaborator

@ybertot ybertot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Thanks for your contribution.

@ybertot ybertot merged commit b527597 into rocq-community:coq-master Feb 6, 2026
1 check passed
@JasonGross JasonGross deleted the attrib-opaque branch February 7, 2026 01:36
@JasonGross
Copy link
Member Author

In a way, this reduces the need for PR #168, because once we extract a graph with opaque nodes marked as such, the behavior of generating a graph where opaque nodes are not traversed could be performed by post-processing.

For opaque nodes, I want to be able to get the dependencies of their statements without getting the dependencies of their bodies.

The fact that you used Claude to produce the code is irrelevant, as was already mentioned in a comment for another pull request. Even more so in this case because the amount of code actually written for this patch is minute.

Indeed, this was just me being lazy (Claude Code automatically inserts the message about itself). I can strip it out in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants