Add opaque, prim, and symb attributes to constant nodes#165
Add opaque, prim, and symb attributes to constant nodes#165ybertot merged 1 commit intorocq-community:coq-masterfrom
Conversation
- OpaqueDef constants get opaque=yes, body=yes - Def constants get opaque=no, body=yes - Undef constants get opaque=yes, body=no - Primitive constants get prim=yes, body=no (no opaque) - Symbol constants get symb=yes, body=no (no opaque) Update all test oracle files and README documentation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
b800129 to
738ab12
Compare
|
Thanks for this contribution. In a way, this reduces the need for PR #168, because once we extract a graph with opaque nodes marked as such, the behavior of generating a graph where opaque nodes are not traversed could be performed by post-processing. |
|
The fact that you used Claude to produce the code is irrelevant, as was already mentioned in a comment for another pull request. Even more so in this case because the amount of code actually written for this patch is minute. |
ybertot
left a comment
There was a problem hiding this comment.
This looks good to me.
Thanks for your contribution.
For opaque nodes, I want to be able to get the dependencies of their statements without getting the dependencies of their bodies.
Indeed, this was just me being lazy (Claude Code automatically inserts the message about itself). I can strip it out in the future. |
I am mostly interested in the
opaqueattribute, and figured I'd add the other ones along side it.Update all test oracle files and README documentation.
🤖 Generated with Claude Code