Draft: Update to support Buildbot 3+#16
Draft
zplizzi wants to merge 1 commit intorockwelln:masterfrom
Draft
Conversation
|
@zplizzi thanks for fixing the issue with depreciated buildbot-slack/buildbot_slack/reporter.py Line 86 in 97d1c89 And I am also wondering when this PR will be merged and a new package will be released? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to #13, this project no longer works with current version of buildbot. This PR includes a working version of this project that has been updated to address this issue - tested on buildbot 3.0.2.
However, I also changed some other stuff to get this working for the project I was working on, so it should be cleaned up and tested thoroughly before a merge. I don't have time to do that, but figured I would at least share it here in case it's helpful to anyone else. Anyone is welcome to take over this PR if they'd like.
Also, here's an example of a report (one of the objects in the
reportslist passed tosendMessage) for reference: