Fix Xcode compiler warning: Implicit conversion loses integer precision:...#35
Open
richrad wants to merge 1 commit intorobbiehanson:masterfrom
Open
Fix Xcode compiler warning: Implicit conversion loses integer precision:...#35richrad wants to merge 1 commit intorobbiehanson:masterfrom
richrad wants to merge 1 commit intorobbiehanson:masterfrom
Conversation
…on: 'NSUInteger' (aka 'unsigned long') to 'int'
|
👍 |
1 similar comment
|
+1 |
Contributor
|
+1, but this is also covered by PR #39. |
|
Simply silencing this one with a cast may not be the right call. So if it's a possibility that the length of the data exceeds 2^32-1, then there should be some code that checks that case. Is that a possibility? Seems like it'd be a pretty crazy edge case if it is... After understanding that concern, I say we just cast it and get rid of this annoying warning :) +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... 'NSUInteger' (aka 'unsigned long') to 'int'