Add CMake package config with exported sexpp::sexpp target - #72
Merged
Conversation
Downstream projects can now consume an installed sexpp via find_package(sexpp) and target_link_libraries(... sexpp::sexpp), in addition to the existing pkg-config file. A version file with SameMajorVersion compatibility is installed as well.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 99.70% 99.71%
=======================================
Files 10 10
Lines 689 700 +11
=======================================
+ Hits 687 698 +11
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a CMake package configuration (sexpp-config.cmake + version file) and exports the sexpp target as sexpp::sexpp, so downstream projects can consume an installed sexpp via find_package(sexpp) — in addition to the existing pkg-config file. This is a prerequisite for making librnp's CMake config properly declare its sexpp dependency (and for packaging sexpp in vcpkg/Conan). Verified locally: configure/build/install to a prefix, then a tiny consumer project using find_package(sexpp) + target_link_libraries(... sexpp::sexpp) builds and runs; pkg-config output is unchanged.