Visibility: better duplicate name lookup#5325
Merged
Conversation
myronmarston
added a commit
to block/elasticgraph
that referenced
this pull request
Apr 17, 2025
This reverts commit d83392c. The performance issue that prompted that commit has been addresed in the GraphQL gem (in rmosolgo/graphql-ruby#5325) and released in 2.5.3, which we recently upgraded to. So there's no reason to continue using the old `Warden` plugin.
myronmarston
added a commit
to block/elasticgraph
that referenced
this pull request
Apr 17, 2025
This reverts commit d83392c. The performance issue that prompted that commit has been addresed in the GraphQL gem (in rmosolgo/graphql-ruby#5325) and released in 2.5.3, which we recently upgraded to. So there's no reason to continue using the old `Warden` plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5324
This code worked fine for small lists, where
.findwas trivial, but for large lists, it's better to use aSet(which uses a Hash under the hood). I think the memory overhead here won't be a problem since the cost here is basically one new Set per uniquely-named list in the current query (6 new objects in the example in #5324, 318 -> 324, but queries which use more distinct GraphQL types during execution will add more objects).