Fix scroll reset when renaming variables in DecompilerWidget - #3648
Fix scroll reset when renaming variables in DecompilerWidget#3648andersendsa wants to merge 1 commit into
Conversation
|
Hi @PremadeS could you pls let me know if the pr needs any changes or if it is good to merge ? |
|
It works, although whenever I scroll the decompiler viewport to the end of a long function (X) and immediately seek to the starting of a different function (Y) (from the functions widget), it scrolls to the ending of "Y" even though it should the start of "Y" as the current seek is there. This makes sense with the current implementation because you're restoring the scrollbar position before every refresh Not a dead breaker however it would be nice to show the decompiled output from the start when seeking to the start of a completely different function :) Note that this only happens if the seek is at the start of the function, seeking to anywhere inside the function works fine |
c9e16d8 to
1d963b5
Compare
|
Hi @PremadeS I have done the changes pls let me know if there are any other changes needed or if it is good to merge |
This commit updates the active history index with the current scrollbar positions immediately prior to initiating a new decompilation request.
Your checklist for this pull request
Detailed description
When renaming variables,
doRefresh()was triggered without updating thescrollHistorywith the current position. This causeddecompilationFinished()to restore the scroll bar to the position of the last explicit seek, effectively resetting the scroll position.Test plan (required)
Closing issues
Closes:#3643