Added mnemonics to main window menu#3523
Draft
amibranch wants to merge 2 commits intorizinorg:devfrom
Draft
Conversation
Member
|
If you are going to do this might at as well do it a bit thoroughly not just the top level menu labels. Not necessarily every item in every submenu, but a good chunk of them could use it. |
Also added nemonics to the NewFileDialog-window buttons
Contributor
Author
|
As suggested, I added mnemonics to some sub-menu points. Also, I added mnemonics to the main buttons in the "NewFileDialog"-Window. If you have any other dialogs in mind where you feel that adding mnemonics provides a benefit, give me a note. However, just a brief check of the translations revealed that they seem to be not working for any string where mnemonics have been added. Do you prefer one of the options:
Note: I guess this PR is blocked now by adding mnemonics-translations to cutter-translations first? Or is this done automagically by CI? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request#3518
Detailed description
The change adds Mnemonics to the main window menu
Test plan (required)
Tests for languages could not be performed locally. Any feedback on how to deal or even test with translations is welcomed!
Closing issues
closes #3518