Graph widget - do not print basic block address - Fixed #3154
Open
M-ismail-ramzan wants to merge 3 commits intorizinorg:devfrom
Open
Graph widget - do not print basic block address - Fixed #3154M-ismail-ramzan wants to merge 3 commits intorizinorg:devfrom
M-ismail-ramzan wants to merge 3 commits intorizinorg:devfrom
Conversation
3 tasks
Member
|
Now it will probably conflict with the setting for linear disassembly view. |
Member
|
Thanks for the PR @M-ismail-ramzan, indeed I experience the same bug. That said, the proposed solution approaches it in the wrong direction as this changes the displaying of the offset across all widgets and not only in graph. The solution should be either in the graph view, in case it does not respect the configuration value, or in Rizin, in case it does not honor this config value when providing the graph response to Cutter. @karliss you probably know which of these causes the issue 🤭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
We encountered an issue when attempting to use the "Show offset for each instruction" feature after clicking "Edit" -> "Preferences". The problem was that it wasn't working as expected. To fix it, I made changes to the code by replacing the API call from "graph.offset" to "asm.offset" and updating other related code accordingly.
Test plan (required)

Before, the button had no effect. Now, it works properly as expected. Below are images of the functioning feature
Closing issues
This pull request closes issue #3144.